Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] main-suyeon 브랜치 최종 동기화 및 자잘한 이슈 적용 #128

Merged
merged 26 commits into from
Jul 7, 2024

Conversation

youz2me
Copy link
Member

@youz2me youz2me commented Jul 6, 2024

🔗 연결된 이슈

📄 작업 내용

  • main 브랜치에 suyeon 브랜치 변경 사항을 병합했습니다.
  • UIViewController로 선언된 VC 파일들 BaseViewController로 변경했습니다.
  • LoginViewController 생성 및 애플 로그인 코드 병합했습니다.
  • 프로비저닝 인증서 추가했습니다. 근데 이슈가 좀 있어서 이 부분은 내일 합숙 시작하면 같이 인증서 맞춰봐야 할 것 같아요! 지금은 실기기는 안되긴 하는데 시뮬은 되는 상태라 일단 올리겠습니다.

@youz2me youz2me self-assigned this Jul 6, 2024
@youz2me youz2me linked an issue Jul 6, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@mmaybei mmaybei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유진아가 수고했어요 !~

Copy link
Contributor

@JinUng41 JinUng41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
내일부터 행복앱잼 화이팅해요~

Comment on lines +15 to +37
super.viewDidLoad()

self.navigationController?.navigationBar.isHidden = true
view.backgroundColor = .yellow
setupAppleLoginButton()
}

func setupAppleLoginButton() {
let button = ASAuthorizationAppleIDButton()
button.addTarget(self, action: #selector(clickAppleLogin), for: .touchUpInside)
button.frame = CGRect(x: 100, y: 100, width: 200, height: 40)
view.addSubview(button)
}

@objc func clickAppleLogin() {
let request = ASAuthorizationAppleIDProvider().createRequest()
request.requestedScopes = [.fullName, .email]

let controller = ASAuthorizationController(authorizationRequests: [request])
controller.delegate = self
controller.presentationContextProvider = self
controller.performRequests()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To. @hooni0918

이러한 부분들은 추후 Base UI Class 를 상속하여 구현할 때, 구현할 코드의 형태가 지금과는 다르게 구현되어야 할 것을 기억해 주시면 좋을 것 같습니다!!

Copy link
Member

@hooni0918 hooni0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셧습니다~

@youz2me youz2me merged commit cde0e03 into suyeon Jul 7, 2024
2 checks passed
@youz2me youz2me added 🛠️ fix 버그나 오류 해결시 사용 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고? labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ fix 버그나 오류 해결시 사용 💚 YouJin 저댄고?저댄고?저댄고?저댄고?저댄고?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hotfix] main-suyeon 브랜치 최종 동기화
4 participants